Fix incorrect decreasing of nesting level in NamespaceResolver#974
Open
weiznich wants to merge 1 commit into
Open
Fix incorrect decreasing of nesting level in NamespaceResolver#974weiznich wants to merge 1 commit into
weiznich wants to merge 1 commit into
Conversation
This commit fixes an incorrect decreasing of the nesting level in the NamespaceResolver through the ns_reader. We could end up there in a state where we request a future decreasing of the nesting level without pushing an actual increase. This could cause namespaces to be unregistered too early. Fix tafia#953
Mingun
reviewed
Jun 30, 2026
Comment on lines
93
to
+97
| Ok(Event::End(e)) => { | ||
| // push a fake element to the `ns_resolver` as the pending pop will remove it again | ||
| // if we don't push this element we don't increase the level, but the subsequent pending pop will | ||
| // decrease it anyway. | ||
| self.ns_resolver.push(&BytesStart::new(""))?; |
Collaborator
There was a problem hiding this comment.
This will only mask the issue in some cases. As described, the root cause lies in the event rewind code, that does not save/restore snapshots of NamespaceResolver state. The correct fix should implement such snapshoting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an incorrect decreasing of the nesting level in the NamespaceResolver through the ns_reader. We could end up there in a state where we request a future decreasing of the nesting level without pushing an actual increase. This could cause namespaces to be unregistered too early.
Fix #953