Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate TransferManager initialization tracebacks to the parent, bound the spawn handshake and SGLang readiness polling, and keep checking worker health after readiness and during completion waits. Preserve the caller's MPI initialization environment. Let multiprocessing collect child exit status instead of a generic SIGCHLD reaper, and close task-owned pipes during shutdown.
Clean the newly created HugeTLB file, mapping and descriptor when a shareable allocation fails. Existing graceful transfer-drain/shutdown timeouts remain in force. The new timeout settings are documented in the configuration reference.
Validation: 13 CPU regressions passed, including a real child initialization exception, child exit during an unbounded wait, invalid/deadline configurations, environment restoration and injected mmap/wrap failures. Applicable pre-commit hooks passed. No GPU/DMA or real HugeTLB allocation acceptance is claimed.