Repository navigation
Adopt new toolchain warnings / lints - #150
Merged
Merged
Conversation
…mp (#149) - Enable verbatimModuleSyntax and noUncheckedSideEffectImports, now that moduleResolution is "bundler". Split all type-only imports into `import type` via the new @typescript-eslint/consistent-type-imports rule (autofixed). Scope verbatimModuleSyntax off for the ts-node override used to load webpack's *.config.ts files as CommonJS. - Switch to eslint-plugin-react-hooks's `recommended` flat config, which now bundles the former eslint-plugin-react-compiler rule set instead of just rules-of-hooks/exhaustive-deps. - Fix the one violation it surfaced: QueryGraphsApp.tsx reset `tree` via setState synchronously inside an effect when treeUrl was cleared. Deriving displayedTree from treeUrl at render time avoids the extra render pass and a one-frame stale-tree flicker.
vogelsgesang
changed the title
vogelsgesang
changed the title
… splitting state Keep `tree` as the single source of truth for what's displayed, rather than introducing a derived `displayedTree` variable. Document the accepted one-frame flicker this causes when treeUrl clears.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt new TS 6.0 / ESLint 10 capabilities enabled by the toolchain bump (#149)
import typevia the new @typescript-eslint/consistent-type-imports rule (autofixed). Scope verbatimModuleSyntax off for the ts-node override used to load webpack's *.config.ts files as CommonJS.recommendedflat config, which now bundles the former eslint-plugin-react-compiler rule set instead of just rules-of-hooks/exhaustive-deps.treevia setState synchronously inside an effect when treeUrl was cleared, leading to a flicker. For now, I just silenced it. Mid-term, I will have to rethink integration with browser navigation.