Batching assemblies throughout workflow - #15
Open
claudiacarter wants to merge 12 commits into
Open
Conversation
Author
|
With buffer_size=4, 2 runs one with bundled output gff3s one unbundled: With buffer_size=1: Tested with new feature_tests.py against results from a run before any changes on the Sanger farm installation of Pannotator (pannotator/v0.1.3-61680a55) as a reference: buffer_size 4: Also checked with scratch=true: |
flass
approved these changes
Sep 1, 2026
Comment on lines
+32
to
+41
| manage_pkls.py unbatch \\ | ||
| --input ${cds_pkl} \\ | ||
| --out-dir cds_unbatched \\ | ||
| --suffix .cds.pkl | ||
|
|
||
| manage_pkls.py unbatch \\ | ||
| --input ${rna_pkl} \\ | ||
| --out-dir rna_unbatched \\ | ||
| --suffix .rna.pkl | ||
|
|
Contributor
There was a problem hiding this comment.
ideally we would not have to unbatch the pickle files here, and simply feed the batch pickle to Bakta, we avoid file count inflation. but that can be implemented later.
at least the scratch directive avoid retention of all those files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are tested and validated on a small test set of assemblies.