Repository navigation
Fix events within tolerance of end - #1390
Merged
Merged
Conversation
If a model is cached, the number of piecewise triggers wasn't being saved.
Events were persisting past the end of a simulation for variable time step integrations.
I had unzipped the llvm binaries using cygwin, and the resulting permissions meant I couldn't actually run llvm-config. This should give me (and others like me) better error messages.
For variable-step simulations, it was possible for an event to fire at the end of an internal step, but after the requested end of the simulation. When the integrator interpolates back to the requested end, it needs to not interpolate back from the event-modified state, but as if the event didn't fire.
When the step sizes are variable, delayed events were firing at the end of a step, regardless of when they should have fired. Need this fix for one of the previous tests, which assumed both fixes were in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For variable-step simulations, it was possible for an event to fire at the end of an internal step, but after the requested end of the simulation. When the integrator interpolates back to the requested end, it needs to not interpolate back from the event-modified state, but as if the event didn't fire.
Fix for #1384.