UpdateRecipesCommand: add --next option - #1059
Closed
gharlan wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
I'm not sure why my new test case fails with
But first I want to ask what do you think about this new option? |
gharlan
force-pushed
the
recipe-update-cmd-next
branch
from
August 2, 2025 15:14
26d22f1 to
af3a64b
Compare
gharlan
force-pushed
the
recipe-update-cmd-next
branch
from
August 2, 2025 15:15
af3a64b to
8c6348b
Compare
gharlan
marked this pull request as ready for review
August 2, 2025 15:16
fabpot
requested changes
Aug 22, 2025
| } | ||
| } | ||
| }, | ||
| "repositories": [ |
Member
There was a problem hiding this comment.
The changes in composer.json should be removed, right?
Contributor
Author
There was a problem hiding this comment.
Without the changes I get this error for the new phpunit test case:
1) Symfony\Flex\Tests\Command\UpdateRecipesCommandTest::testCommandUpdatesRecipe with data set #1 (array(true))
Failed asserting that '<warning>Symfony recipes are disabled: "symfony/flex" not found in the root composer.json\n
All packages appear to be up-to-date!\n
' contains "Recipe updated".
That's why I added symfony/flex to this composer.json (it is not the main one). Don't know if there is maybe a better solution?
Member
|
Looks like running in non-interactive mode provides the same experience, no?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
symfony:recipes:updateyou can update the recipes, but you have to do it one by one.I suggest to add a
--nextoption to update the next outdated package. So you do not need to select the next package interactively.