🍒 [BoundsSafety][CodeGen] don't create invalid conditional branches - #13588
Merged
hnrklssn merged 1 commit intoJul 31, 2026
Merged
Conversation
[BoundsSafety][CodeGen] don't create invalid conditional branches (cherry picked from commit 24620a1)
Member
Author
|
@swift-ci test llvm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For null checks we would previously create a conditional branch but leave the second target block as nullptr and update it later with the correct block, after it had been created. Now that conditional and unconditional branches are different opcodes, conditional branches are defined as always having two successors, so the successors iterator no longer checks for null before casting. When inside a loop, the LoopInfoStack helper class would inspect all inserted terminator instructions' successors to determine whether the new terminator is the loop latch, leading to the crash.
Avoid this by creating the successor eagerly.
rdar://182676090
(cherry picked from commit 24620a1)