[LLDB] Fix "Data" Dataformatter - #13564
Open
adrian-prantl wants to merge 2 commits into
Open
Conversation
This reverts commit 6d6f806.
adrian-prantl
requested review from
JDevlieghere,
charles-zablit and
kastiglione
July 29, 2026 18:33
Author
|
@swift-ci test |
Author
|
@swift-ci test windows |
JDevlieghere
approved these changes
Jul 29, 2026
Author
|
@swift-ci test windows |
charles-zablit
approved these changes
Jul 30, 2026
This patch fixes two bugs in the Data dataformatter: 1. tighten up the check for the FoundationEssentials layout which occasionally produces false positives in CI (addressed by also checking the size of the _slice field) 2. while implementing the above I noticed the formatter hardcodes the size of Int to 64 bits (addressed by using pointer size) 3. revert the relaxation of the Data tests to work around issue (1) rdar://182785830 Assisted-by: claude
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes two bugs in the Data dataformatter:
tighten up the check for the FoundationEssentials layout which
occasionally produces false positives in CI (addressed by also
checking the size of the _slice field)
while implementing the above I noticed the formatter hardcodes the
size of Int to 64 bits (addressed by using pointer size)
revert the relaxation of the Data tests to work around issue (1)
rdar://182785830
Assisted-by: claude