[lldb] Discern embedded swift tests that can't run vs buggy ones - #13545
Open
augusto2112 wants to merge 2 commits into
Open
[lldb] Discern embedded swift tests that can't run vs buggy ones#13545augusto2112 wants to merge 2 commits into
augusto2112 wants to merge 2 commits into
Conversation
Author
|
@swift-ci test |
augusto2112
force-pushed
the
embedded-decorator-change
branch
from
July 28, 2026 23:31
562209c to
d53524a
Compare
Author
|
@swift-ci test |
augusto2112
force-pushed
the
embedded-decorator-change
branch
from
July 29, 2026 23:13
d53524a to
cadcabd
Compare
Author
|
@swift-ci test |
augusto2112
marked this pull request as ready for review
July 30, 2026 02:50
Author
|
@swift-ci test Windows |
`@skipEmbeddedSwift` doesn't really tell us if the test is skipped
because there's a bug vs tests that simply can't run in embedded swift
mode (for example, dylibs, objc interop, resiliency, etc).
Introduce requiresNonEmbeddedSwift to mean "this can't run in embedded
swift mode" and leave skipEmbeddedSwift to identify tests that should be
fixed.
The split was measured by removing every annotation and running
check-lldb-swift in the swiftembed variant:
annotations test files
moved to requiresNonEmbeddedSwift 369 284
narrowed to skipEmbeddedSwiftOnLinux 2 2
removed, the test already passes 21 16
kept as skipEmbeddedSwift (a bug to fix) 83 73
----------- ----------
before 475 371
The test-file column adds up to more than 371 because four files have
annotations in more than one row.
That first measurement only covered macOS arm64. CI also covers macOS x86_64
and Linux x86_64, where four of the tests it had cleared still fail, so those
keep an annotation:
TestSwiftArchetypeResolution skipEmbeddedSwiftOnLinux: the inferior does not
link, undefined reference to arc4random_buf
from the embedded stdlib's hashing seed.
TestSwiftCommandMemoryFind skipEmbeddedSwiftOnLinux: `memory find -e`
reports "data not found within the range".
TestSwiftStepping skipEmbeddedSwift: steps to line 174 instead of
172 on x86_64, and hits the same arc4random_buf
link failure on Linux.
TestSwiftTypes skipEmbeddedSwift: `frame variable --raw
float80` crashes LLDB with "80 != 128". Float80
only exists on x86_64, which is why arm64
passed.
Assisted-by: claude
augusto2112
force-pushed
the
embedded-decorator-change
branch
from
July 30, 2026 19:22
cadcabd to
3110ac1
Compare
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.