Repository navigation
Conversation
The compiler drops grouping parens from each-block expressions, and
Prettier then omits them as unnecessary in JS, which collides with the
{#each} as context keyword.
Fixes sveltejs#486
Author
|
Closing this. Not something I'm going to keep current. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{#each (Object.entries(modes) as [Mode, string][]) as [id, name]}was printed as{#each Object.entries(modes) as [Mode, string][] as [id, name]}. The compiler drops grouping parentheses from the each-block expression AST, and Prettier then omits them as unnecessary in JS, so the TypeScriptasis concatenated into the{#each}ascontext keyword.{#each}expressions whose AST type isTSAsExpressionso the assertion stays parenthesized.Decision
node.expression.type === 'TSAsExpression'.satisfies/ angle-bracket assertions).{#each (a, b) as item}, only wrap when{#each}'saswould otherwise collide with TypeScriptas. Sequence expressions already get parens from Prettier;TSAsExpressionis the hole. Happy to widen the predicate if you want that.The
bind:value={((x as T).y as U).z}case from the issue comment is already handled by the existingbind:parentheses fix (#501 / #503); this PR does not change that path.Test plan
test/printer/samples/each-block-type-assertion.htmlfails without the wrap and passes with it{#each}printer samples,typescript-template, andpnpm teststill pass