✨(components) add bottomMessage to DropdownMenu component - #297
Merged
Conversation
As for topMessage, bottomMessage is a prop that allows you to add a message at the bottom of the dropdown menu. It can be used to provide additional information or context to the user. We replace the Header component with a simple div element to display the message, Header component was adding header tag, that was not semantically correct for this use case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
As for
topMessage,bottomMessageis a prop that allows you to add a message at the bottom of thedropdown menu.
It can be used to provide additional information or context to the user.
We replace the
Headercomponent with a simple div element to display the message,Headercomponent wasadding header tag, that was not semantically correct for this use case.
Related to suitenumerique/docs#2549 (comment)
Demo