馃悰(backend) block item delete by creator without access - #814
Open
NathanVss wants to merge 1 commit into
Open
Conversation
Deleting an item relied on the creator field alone, which is an immutable historical reference. A user could still delete an item they created inside a shared folder after their access was revoked, wiping the whole subtree including the owner's content. Gate the creator branch on holding editor access so the ability is lost as soon as access is revoked, matching the update permission.
|
Collaborator
|
I think we should wait for #756 , or rebase this PR in top of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix a broken access control issue in item deletion.
A user could delete an item they had created inside a folder shared with them, even after the owner had revoked their access. Because the delete permission relied on the
creatorfield alone (an immutable historical reference), revoking the share left the delete ability intact. The user could then callDELETE /api/v1.0/items/<id>/on a subfolder they once created and soft-delete the whole subtree, including files and folders added by the owner.Changes
Item.get_abilitieson the user still holding editor access on the item. The ability is now lost as soon as access is revoked, consistent with the update permission.