Skip to content

✨(frontend) add markdown download option - #2608

Open
gokul-debugger wants to merge 2 commits into
suitenumerique:mainfrom
gokul-debugger:feature/markdown-download
Open

✨(frontend) add markdown download option#2608
gokul-debugger wants to merge 2 commits into
suitenumerique:mainfrom
gokul-debugger:feature/markdown-download

Conversation

@gokul-debugger

@gokul-debugger gokul-debugger commented Aug 27, 2026

Copy link
Copy Markdown

Purpose

Add Markdown to the document download menu so users can export document
content directly as a .md file.

Closes #2605.

Proposal

  • Reuse the existing Markdown conversion logic
  • Download the file using the document title
  • Add Markdown to the download dropdown
  • Update the supported export formats message
  • Add focused coverage for Markdown downloads

External contributions

Thank you for your contribution! 🎉

Please ensure the following items are checked before submitting your pull request:

General requirements

Skip the checkbox below 👇 if you're fixing an issue or adding documentation

  • Before submitting a PR for a new feature I made sure to contact the product manager

CI requirements

  • I made sure that all existing tests are passing
  • I have signed off my commits with git commit --signoff (DCO compliance)
  • I have signed my commits with my SSH or GPG key (git commit -S)
  • My commit messages follow the required format: <gitmoji>(type) title description
  • I have added a changelog entry under ## [Unreleased] section (if noticeable change)

AI requirements

  • I used AI assistance to produce part or all of this contribution
  • I have read, reviewed, understood and can explain the code I am submitting
  • I can jump in a call or a chat to explain my work to a maintainer

Tool used: ChatGPT, for codebase understanding and implementation review.

Testing

  • Frontend lint suite passed
  • App unit suite passed: 300 tests
  • Production frontend build passed
  • Focused Chromium Playwright E2E passed: Markdown export, filename, and downloaded content verified

Reuse the editor's Markdown serializer to download document content as a UTF-8 .md file. Add browser coverage for the filename and exported content.

Signed-off-by: Gokul Krishna <gokul.06krishna@gmail.com>
Add the Markdown download option to the unreleased changelog for pull request suitenumerique#2608.

Signed-off-by: Gokul Krishna <gokul.06krishna@gmail.com>
@gokul-debugger
gokul-debugger marked this pull request as ready for review August 27, 2026 17:04
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 021bf2e0-38e9-448e-b3a0-cf401c449c6b

📥 Commits

Reviewing files that changed from the base of the PR and between 944ea13 and bcbe755.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • src/frontend/apps/e2e/__tests__/app-impress/doc-export.spec.ts
  • src/frontend/apps/impress/src/features/docs/doc-export/components/ModalExport.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

The document export modal now includes Markdown as an available format. It generates a UTF-8 Markdown Blob when the configured exporter returns no Blob and uses the .md extension for downloads. The end-to-end coverage selects Markdown, checks the filename, and verifies the downloaded content. The changelog records the new frontend download option.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to bcbe7

This PR adds a browser-local Markdown download option using the existing export flow and does not broaden document access or introduce service changes. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: antolc, ovgodd

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes satisfy issue #2605 by adding a Markdown download option, reusing document Markdown conversion, producing UTF-8 .md files, and adding focused coverage.
Out of Scope Changes check ✅ Passed The changelog update, export modal change, and end-to-end test are directly related to the Markdown download objective. No unrelated changes are identified.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a Markdown download option to the frontend.
Description check ✅ Passed The description directly explains the Markdown export feature, implementation proposal, testing, and related issue.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AntoLC
AntoLC self-requested a review August 28, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Markdown as Option in Download dropdown menu

1 participant