Skip to content

Use typed lookup stage formatting - #20

Merged
suchapalaver merged 1 commit into
mainfrom
fix-17-static-str-api-surfaces
Jul 12, 2026
Merged

suchapalaver merged 1 commit into
mainfrom
fix-17-static-str-api-surfaces

Conversation

@suchapalaver

Copy link
Copy Markdown
Owner

Summary

  • add Display for CombinedDataLookupStage and format lookup failures through the typed stage
  • keep operation_name() for compatibility as the stable RPC operation label
  • record the remaining &'static str surfaces as intentional labels: cache backend names, event/network labels, and test-only scan error payloads

Closes #17.

Verification

  • cargo fmt
  • nix shell nixpkgs#stdenv.cc -c cargo test --all-features retrieval::types::tests::test_combined_lookup_stage_display_matches_rpc_operation_name
  • nix shell nixpkgs#stdenv.cc -c cargo test --all-features
  • nix shell nixpkgs#stdenv.cc -c cargo clippy --all-targets --all-features -- -D warnings
  • nix shell nixpkgs#reuse -c reuse lint

@suchapalaver
suchapalaver merged commit 8ca7c28 into main Jul 12, 2026
11 checks passed
@suchapalaver
suchapalaver deleted the fix-17-static-str-api-surfaces branch July 12, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate remaining &'static str API surfaces

1 participant