Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Add throttle and fault tags to X-Ray - #752

Open
gphat wants to merge 1 commit into
stripe:masterfrom
gphat:cory-xray-features
Open

Add throttle and fault tags to X-Ray#752
gphat wants to merge 1 commit into
stripe:masterfrom
gphat:cory-xray-features

Conversation

@gphat

@gphat gphat commented Aug 22, 2019

Copy link
Copy Markdown
Contributor

Summary

Adds throttle and fault capability to the X-Ray sink.

Motivation

X-Ray has three different error-like attributes but the conversion from SSFSpan to XRaySegment has nothing to use for these fields.

This adds two new config options that, when the tags are present, sets these fields.

Test plan

Added tests.

@gphat gphat changed the title Add throttle and fault tags to XRay Add throttle and fault tags to X-Ray Aug 22, 2019
@stripe-ci

Copy link
Copy Markdown

Gerald Rule: Copy Observability on Veneur, Unilog, Falconer pull requests

cc @stripe/observability
@stripe/observability-stripe

@gphat

gphat commented Aug 24, 2019

Copy link
Copy Markdown
Contributor Author

(These tests pass locally for me, fwiw. I can't trigger a re-run to test for flakes.)

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants