Skip to content

use google translate to translate page - #451

Open
shakilhossain1 wants to merge 2 commits into
mainfrom
feature/language
Open

use google translate to translate page#451
shakilhossain1 wants to merge 2 commits into
mainfrom
feature/language

Conversation

@shakilhossain1

Copy link
Copy Markdown
Collaborator

No description provided.

@jbeard4
jbeard4 temporarily deployed to yourpeer-feature-langua-pieef7 August 15, 2025 11:03 Inactive

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not safe to approve yet. The PR introduces likely behavior regressions in translation availability and robustness, and lacks validation for risky client-side script behavior.

Blocking issues

  • Potential regression: translation initialization was removed from page/layout wrappers (src/app/[route]/layout.tsx, src/app/page.tsx) and replaced with a selector only rendered in src/components/Navbar.tsx. Route/layout variants that do not render this navbar may lose translation support entirely.
  • changeLanguage in src/components/google-translate.tsx can schedule unbounded setTimeout retries if .goog-te-combo never appears (script blocked/failed), creating a persistent timer loop/performance leak with no retry cap or cleanup.
  • Risky logic change is untested: no tests were added for script-load failure handling, language persistence, or behavior across non-home routes. Given direct third-party script injection and DOM-driven translation state, this should be covered before approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants