use google translate to translate page - #451
Open
shakilhossain1 wants to merge 2 commits into
Open
Conversation
shakilhossain1
temporarily deployed
to
CI_CD_PIPELINE
February 27, 2026 13:47 — with
GitHub Actions
Inactive
There was a problem hiding this comment.
Not safe to approve yet. The PR introduces likely behavior regressions in translation availability and robustness, and lacks validation for risky client-side script behavior.
Blocking issues
- Potential regression: translation initialization was removed from page/layout wrappers (
src/app/[route]/layout.tsx,src/app/page.tsx) and replaced with a selector only rendered insrc/components/Navbar.tsx. Route/layout variants that do not render this navbar may lose translation support entirely. changeLanguageinsrc/components/google-translate.tsxcan schedule unboundedsetTimeoutretries if.goog-te-combonever appears (script blocked/failed), creating a persistent timer loop/performance leak with no retry cap or cleanup.- Risky logic change is untested: no tests were added for script-load failure handling, language persistence, or behavior across non-home routes. Given direct third-party script injection and DOM-driven translation state, this should be covered before approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.