docs: clarify Lambda DB pool sizing and sequential query behavior - #213
Open
jbeard4 wants to merge 1 commit into
Open
docs: clarify Lambda DB pool sizing and sequential query behavior#213jbeard4 wants to merge 1 commit into
jbeard4 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DATABASE_POOL_MAX=1is safe for Lambda given that the codebase usesPromise.all(...)fan-outs for some DB work.Description
README.mdto addDATABASE_POOL_MAXandDATABASE_POOL_MINenvironment variable docs and aLambda connection pooling notethat explains presence ofPromise.all(...)queries and whypool.max=1is acceptable for per-Lambda environments while noting the latency tradeoff for fan-out endpoints.Testing
rg) to confirmPromise.all(...)fan-outs and inspectedsrc/config.jsto verify the defaultpool.maxbehavior, and ran the repository pre-commit lint check which failed due to unrelated repo lint errors; no unit/integration tests were executed for this docs-only change.Codex Task