Avoid RDS proxy session pinning - #169
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| dialectOptions: { | ||
| clientMinMessages: false, // avoid issuing SET client_min_messages |
There was a problem hiding this comment.
Invalid client_min_messages value may block connections
Postgres accepts only log-level strings for client_min_messages (e.g., warning, notice); setting dialectOptions.clientMinMessages to the boolean false means Sequelize will issue SET client_min_messages TO false during connection setup, which Postgres rejects with invalid value for parameter "client_min_messages": "false". When this runs against a Postgres backend, the app will fail to acquire a database connection instead of simply avoiding session pinning. Consider omitting the option or using a valid log level string.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task