Repository navigation
index-builder: serve health check on --index-builder-grpc-listen-addr - #289
Open
YaroShkvorets wants to merge 2 commits into
Open
YaroShkvorets wants to merge 2 commits into
YaroShkvorets wants to merge 2 commits into
Conversation
The index builder never listened on --index-builder-grpc-listen-addr: its health handlers were never registered on a server, and App.Run only dialed that address for IsReady(). Start the gRPC server and register the health service, as the merger does. Add --index-builder-http-healthz-addr (default :10019), the same HTTP /healthz the merger and relayer expose since v1.14.4. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maoueh
requested changes
Oct 9, 2026
maoueh
left a comment
maoueh
left a comment
Contributor
There was a problem hiding this comment.
Let's use the same endpoint for the /healthz location, we never created dedicated flags, so let's serve under index-builder-grpc-listen-addr directly.
Also, dgrpc has support to configure the grpc server with health check so it can be configured to it.
Per review: drop the dedicated --index-builder-http-healthz-addr and let dgrpc's WithHealthCheck serve both gRPC health and HTTP /healthz on --index-builder-grpc-listen-addr. Removes the unused hand-written health handlers and keeps NewIndexBuilder's signature unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
YaroShkvorets
changed the title
Contributor
Author
|
Changed. Using the same pattern with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The index builder never listened on
--index-builder-grpc-listen-addr. Its health handlers were never registered on a server, andApp.Runonly created a client to that address forIsReady(). Liveness probes on that port gotconnection refused, andIsReady()was always false.This starts a dgrpc server on that address with
WithHealthCheck(HealthCheckOverGRPC|HealthCheckOverHTTP, …), which serves both gRPC health and HTTP/healthz. It reports ready except during the graceful-shutdown delay. The unused hand-written handlers inindex-builder/healthz.goare removed.🤖 Generated with Claude Code