fix(MetaVerifier): add TCB bridge axiom for Lean 4.31 kernel compat - #1453
Open
kondylidou wants to merge 4 commits into
Open
fix(MetaVerifier): add TCB bridge axiom for Lean 4.31 kernel compat#1453kondylidou wants to merge 4 commits into
kondylidou wants to merge 4 commits into
Conversation
Lean 4.31 changed kernel reduction of auxiliary `_match_N` functions generated by complex patterns in `denoteQueries`/`denoteTerm`. This broke `gen_smt_vcs`: the final `mv.assign hP` step requires the kernel to reduce `denoteQueries evcs` to `andN ps`, which it can no longer do. Following Joe Hendrix's recommendation (issue strata-org#1442), make `translateQuery` part of the trusted computing base by adding a per-theorem local axiom that bridges the `translateQuery`-based conjunction `andN ps` to the `smtVCsCorrect` goal type. The axiom is applied only after the user has discharged every individual VC subgoal, so soundness is preserved within the TCB assumption for `translateQuery`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
Contributor
|
Could you give an example test file with the resulting #print axioms? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lean 4.31 changed kernel reduction of
_match_Nauxiliary functionsgenerated by complex patterns in
denoteQueries/denoteTerm, breakinggen_smt_vcs: themv.assign hPstep required the kernel to reducedenoteQueries evcstoandN ps, which it can no longer do.Per Joe Hendrix's recommendation (issue #1442), make
translateQuerypart of the TCB by adding a per-theorem local axiom bridging
andN ps → (denoteQueries evcs).getD Falseat elaboration time.The axiom is only applied after the user proves every individual VC
subgoal. The axiom name appears in
#print axioms, keeping trustexplicit.
Closes #1442