Repository navigation
Add NIHIL to We Recommend - #654
Merged
Merged
Conversation
A modern alternative metal band from Argentina, added to Artists & Creators. The list lives in two places and both needed it: FRIEND_GROUPS for the in-app dialog, and the table in the README. The avatar is their Instagram profile picture at 150x150, matching the other entries in that folder, bundled locally like the rest so the dialog still renders with no network. The role line is in all ten language tables rather than English only, since a missing key falls back to English silently and would have read untranslated everywhere else. Japanese and Chinese keep the two sentence shape rather than a comma chain, which reads badly in both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #653
NIHIL, a modern alternative metal band from Argentina, added to Artists & Creators.
Both copies of the list, since nothing checks that they agree:
FRIEND_GROUPSinstatic/js/catalog.js, for the dialog in the appREADME.md, for anyone reading the project on GitHubThe avatar is their Instagram profile picture at 150x150, which is the size the other entries in
static/img/friends/use, bundled locally like the rest so the dialog still renders with no network.The role line is in all ten language tables rather than English only.
t()falls back to English for a missing key, so an English only entry would have looked correct while testing and read untranslated in nine languages. Japanese and Chinese keep the two sentence shape instead of a comma chain, which reads badly in both.Verified
The full Playwright suite (183 passing), pytest (1078 passing),
node --checkacrossstatic/js, the JS unit tests, i18n coverage clean at 526 keys per table, anduv.lockuntouched.