Repository navigation
Name the structure toggle for the import it changes - #652
Merged
Merged
Conversation
A reporter clicked "Song structure" on an open track, watched the button change colour, and saw the sections bar stay exactly where it was (#634). The button and the bar are unrelated. The button is a server-side flag the pipeline reads once per job, so it can only affect the next import; the bar is a permanent part of the studio showing whatever sections a track already has, detected or added by hand. Nothing the button does can reach a track that has already been separated. Two things made that read as a fault. The name described the structure rather than the work, so it looked like the switch that shows and hides the bar. And the toggle clears itself every time a song loads, since an inference pass costs minutes of CPU and should never be inherited from the last track: the user therefore finds it off after an import, clicks it expecting off, and gets on. So it is called "Detect structure" now, and the tooltip says it applies to the next import rather than to an open track, and points at the control that does own the bar: "Sections" in the Collapse row, which has been there since before this was reported. No behaviour changes. The title is three sentences, which is right for a tooltip and wrong for a screen reader, so structure.toggleAria carries a short label instead of pointing at the same key. Ten tables, each naming its own locale's menu path rather than the English one. Two tests: that the toggle leaves the sections bar alone in both directions while the panel toggle still hides it, and that the label names the import. The first is the reported behaviour, the second is the fix. Verified: pytest (1078 passing), ruff, bandit, the full Playwright suite (183), node --check, the JS unit tests, i18n coverage clean at 525 keys per table, and cargo fmt, clippy and test unchanged at 99. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #634
A reporter clicked "Song structure" on an open track, watched the button change colour, and saw the sections bar stay exactly where it was.
What is actually going on
The button and the bar are unrelated. The button is a server-side flag the pipeline reads once per job, so it can only ever affect the next import. The bar is a permanent part of the studio, showing whatever sections a track already has, whether detected at import or added by hand. Nothing the button does can reach a track that has already been separated.
Two things made that read as a fault:
What changed
Wording only, no behaviour.
structure.toggleAriais new. The title is three sentences, which is right for a tooltip and wrong for a screen reader, so the aria label is short instead of reusing the title key.Tests
Two, both in the existing spec. The first is the reported behaviour: the toggle leaves the sections bar alone in both directions, while the panel toggle still hides and shows it. The second pins the label, since naming the import is the whole fix and is otherwise the sort of thing a later tidy-up would undo.
Verified
pytest (1078 passing), ruff check and format, bandit, the full Playwright suite (183 passing),
node --check, the JS unit tests, i18n coverage clean at 525 keys per table,uv.lockuntouched, and cargo fmt, clippy and test unchanged at 99.