Repository navigation
Delete widgets.css, which nothing has loaded since May - #613
Merged
Merged
Conversation
1609 lines of stylesheet that no page has ever asked for. The three HTML entry points load: variables/waves/daw (static/index.html), mobile/styles (static/mobile/index.html), setup (desktop/ui/index.html). None of them names this file, nothing @imports it, and no script, packaging script or Dockerfile references it. It was last meaningfully touched in #27, before the DAW redesign replaced it with daw.css. Nothing to regression-test, and that is the whole argument rather than a hopeful one: an unloaded stylesheet has no effect on rendering, so the app already looks the way it does without it. The full e2e suite passes with it gone, which confirms rather than establishes that. It was not free to keep. The refusal message in #584 was styled here first and was completely invisible, because the rules were never loaded. That cost a debugging round and was only caught because the test asserted the computed colour rather than the presence of a class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1609 lines of stylesheet that no page asks for.
Why it is safe
The three HTML entry points load:
static/index.htmlvariables.css,waves.css,daw.cssstatic/mobile/index.htmlmobile/styles.cssdesktop/ui/index.htmlsetup.cssNone names this file. Nothing
@imports it. No script, packaging script or Dockerfile references it. It was last meaningfully touched in #27, before the DAW redesign replaced it withdaw.css.The argument is that an unloaded stylesheet has no effect on rendering, so the app already looks the way it does without it. There is nothing to regression-test. The full e2e suite (148) passes with it gone, which confirms that rather than establishing it.
Why it was worth removing rather than ignoring
The refusal message in #584 was styled in here first and was completely invisible, because the rules were never loaded. It cost a debugging round, and was only caught because the test asserted the computed colour rather than the presence of a class. A dead file that still looks live is a trap for exactly that.