Repository navigation
Conversation
…teemit#3240) - Resolves steemit#3240: condenser_api.get_content active_votes reports all reputations as 0 when follow_api is disabled. - Added else if (_reputation_api) fallback in get_active_votes to query account reputations from reputation_api_plugin, consistent with other methods across condenser_api.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3240.
Problem
When
condenser_api.get_content(orget_active_votes) is called on nodes that runreputation_api_pluginwithoutfollow_api_plugin(standard configuration on modern nodes wherefollow_apiis disabled/deprecated in favor of Hivemind / reputation plugins), all voter reputations inactive_votesare returned as0.While other methods in
condenser_apihave anelse if (_reputation_api)fallback to query reputations fromreputation_api,get_active_votesonly checkedif (_follow_api).Solution
In
condenser_api_impl::get_active_votes, added anelse if (_reputation_api)block to look up voter reputation via_reputation_api->get_account_reputations(...), aligning it with the rest ofcondenser_api.Verification
UNIT_TEST=ON). All unit tests passed cleanly.