Skip to content

test: ensure backward compatibility in test assertion #13783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 2 commits into from
Jul 30, 2026
+4 −3
Merged

test: ensure backward compatibility in test assertion #13783

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4574b9
test(@stdlib/dstructs/named-typed-tuple): fix locale-specific `toLoca…
claude Jul 30, 2026
2986fb2
test: use string interpolation
kgryte Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/node_modules/@stdlib/dstructs/named-typed-tuple/test/test.to_locale_string.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
var tape = require( 'tape' );
var hasProp = require( '@stdlib/assert/has-property' );
var isFunction = require( '@stdlib/assert/is-function' );
var format = require( '@stdlib/string/format' );
var namedtypedtuple = require( './../lib' );


Expand Down Expand Up @@ -87,7 +88,7 @@ tape( 'the method serializes a tuple as a locale-specific string (default locale
Point = namedtypedtuple( [ 'price', 'quantity' ] );
p = new Point( [ 123456.789, 9876 ] );

expected = 'tuple(price=' + (123456.789).toLocaleString() + ', quantity=' + (9876).toLocaleString() + ')';
expected = format( 'tuple(price=%s, quantity=%s)', (123456.789).toLocaleString(), (9876).toLocaleString() );
actual = p.toLocaleString();

t.strictEqual( actual, expected, 'returns expected value' );
Expand All @@ -103,7 +104,7 @@ tape( 'the method serializes a tuple as a locale-specific string (specified loca
Point = namedtypedtuple( [ 'price', 'quantity' ] );
p = new Point( [ 123456.789, 9876 ] );

expected = 'tuple(price=123.456,789, quantity=9.876)';
expected = format( 'tuple(price=%s, quantity=%s)', (123456.789).toLocaleString( 'de-DE' ), (9876).toLocaleString( 'de-DE' ) );
actual = p.toLocaleString( 'de-DE' );

t.strictEqual( actual, expected, 'returns expected value' );
Expand All @@ -124,7 +125,7 @@ tape( 'the method serializes a tuple as a locale-specific string (locale and opt
'currency': 'USD'
};

expected = 'tuple(price=' + (1234.56).toLocaleString( 'en-US', opts ) + ', quantity=' + (50).toLocaleString( 'en-US', opts ) + ')';
expected = format( 'tuple(price=%s, quantity=%s)', (1234.56).toLocaleString( 'en-US', opts ), (50).toLocaleString( 'en-US', opts ) );
actual = p.toLocaleString( 'en-US', opts );

t.strictEqual( actual, expected, 'returns expected value' );
Expand Down