-
Notifications
You must be signed in to change notification settings - Fork 78
Support [[note#heading]] wiki-link anchors (discussion #105)
#748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
srid
wants to merge
9
commits into
master
Choose a base branch
from
heading-link
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1856add
feat: support #anchor in wikilinks for cross-file heading links
srid 4b108c2
refactor(lowy): docs — note Pandoc {#custom-id} attribute behavior fo…
srid 10cb992
fix(lowy): MCP resolveWikilink strips #anchor so it agrees with renderer
srid a28a105
refactor(lowy): mark embed #anchor discard as a #105 follow-up
srid e07fe00
refactor(hickey): pull commonmark-wikilink dedupe (local plainify' ta…
srid 0e4e82e
fix(police): test — explicit case match on resolveWikilink instead of…
srid 8f46191
test(e2e): match href anchor only (mode-agnostic)
srid 7a1b242
refactor: use upstream WL.parseWikiLinkUrl in MCP resolver
srid da81daa
test: pull commonmark-wikilink ^blockid parse test
srid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Heading target | ||
|
|
||
| Intro paragraph. | ||
|
|
||
| ## Alpha Section | ||
|
|
||
| This section is the wikilink-anchor jump target. | ||
|
|
||
| ## Beta Section | ||
|
|
||
| This section exists so the auto-id slugs distinguish two headings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Wikilink heading anchor | ||
|
|
||
| A cross-file heading link: [[heading-target#alpha-section]]. | ||
|
|
||
| With a custom title: [[heading-target#alpha-section|jump to alpha]]. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we upstream this to commonmark-wikilink?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstreamed as
WL.parseWikiLinkUrl :: Text -> Maybe (WikiLink, Maybe Anchor)in srid/commonmark-wikilink@a3e5938. It's the non-Pandoc counterpart todelineateLink— does the slash-split, slug-decode, and anchor-strip in one call.Emanote MCP is now a one-liner that just discards the anchor (commit 7a1b242 on this PR), with a comment naming why the asymmetry from the HTML renderer (which keeps the anchor) is intentional.