Repository navigation
Keep reader container running when listener throws - #1551
Merged
sobychacko merged 1 commit intoSep 22, 2026
Merged
sobychacko merged 1 commit into
sobychacko merged 1 commit into
Conversation
InternalAsyncReader only caught PulsarClientException, so any exception thrown by the reader listener (e.g. a failing @PulsarReader handler) escaped the read loop and silently terminated the reader thread while the container still reported itself as running. Catch and log listener exceptions so the reader continues with the next message. Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InternalAsyncReader only caught PulsarClientException, so any exception thrown by the reader listener (e.g. a failing @PulsarReader handler) escaped the read loop and silently terminated the reader thread while the container still reported itself as running.
Catch and log listener exceptions so the reader continues with the next message.