Add password support to Redis chat memory autoconfigure#6637
Open
OneZero-Y wants to merge 1 commit into
Open
Conversation
Expose spring.ai.chat.memory.repository.redis.password and wire it into the Jedis RedisClient when configured. Keep legacy spring.ai.chat.memory.redis prefix delegation and document the new property. Fixes spring-projects#6621 Signed-off-by: Bishen Yu <aukovyps@163.com>
Contributor
Author
|
Hey @dimitarproynov — would you mind taking a look when you get a chance? This adds optional password support to Redis chat memory autoconfigure (spring.ai.chat.memory.repository.redis.password), with the legacy spring.ai.chat.memory.redis.* prefix still delegated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6621
Summary
Redis chat memory autoconfiguration supports
hostandport, but notpassword. Users with password-protected Redis instances had to provide their ownRedisClientbean instead of usingspring.ai.chat.memory.repository.redis.*properties.This PR adds an optional
passwordproperty and wires it into the JedisRedisClientwhen configured. The legacyspring.ai.chat.memory.redis.*prefix continues to work via delegation.Changes
passwordtoRedisChatMemoryRepositoryPropertiesRedisClientinRedisChatMemoryRepositoryAutoConfigurationpasswordin deprecatedRedisChatMemoryPropertiesfor the legacy prefixspring.ai.chat.memory.repository.redis.passwordinchat-memory.adocConfiguration
Legacy prefix (still supported):
Test plan