Validate and parameterize Neo4j chat memory labels#6635
Closed
sobychacko wants to merge 1 commit into
Closed
Conversation
Complete the label-hardening (originally done via See 1c06d7c) in Neo4jChatMemoryRepository by converting deleteByConversationId() to use dynamic label parameter syntax `($($label))` consistently with the other query methods. Add label validation to Neo4jChatMemoryRepositoryConfig to ensure all configured labels are valid Neo4j identifiers before they are used in index creation statements, throwing IllegalArgumentException at startup if an invalid value is supplied. Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>
ilayaperumalg
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete the label-hardening (originally done via See 1c06d7c) in Neo4jChatMemoryRepository by converting deleteByConversationId() to use dynamic label parameter syntax
($($label))consistently with the other query methods.Add label validation to Neo4jChatMemoryRepositoryConfig to ensure all configured labels are valid Neo4j identifiers before they are used in index creation statements, throwing IllegalArgumentException at startup if an invalid value is supplied.