Replace System.out with debug-level logging in ParagraphManager#6632
Open
sumitvairagar wants to merge 1 commit into
Open
Replace System.out with debug-level logging in ParagraphManager#6632sumitvairagar wants to merge 1 commit into
ParagraphManager#6632sumitvairagar wants to merge 1 commit into
Conversation
The ParagraphManager constructor unconditionally prints the PDF document outline (Table of Contents) to System.out via printParagraph(). This pollutes application logs and cannot be controlled through logging configuration. Replace the System.out usage with a debug-level log guard using Commons Logging, consistent with sibling classes PagePdfDocumentReader and ForkPDFLayoutTextStripper. Add a regression test verifying no stdout output during initialization. Fixes spring-projects#6599 Signed-off-by: sumitvairagar <sumit.vairagar@gmail.com>
sdeleuze
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ParagraphManagerconstructor unconditionally callsprintParagraph(this.rootParagraph, System.out), dumping the entire PDF outline to stdout on everyParagraphPdfDocumentReaderinstantiation.This cannot be controlled through logging configuration and produces noisy output when processing multiple PDFs.
Changes:
System.outusage with Commons Logging at DEBUG levelisDebugEnabled()guard to avoid tree traversal when not neededprintParagraph→logParagraphto reflect new behaviorThe logging pattern matches sibling classes
PagePdfDocumentReaderandForkPDFLayoutTextStripper.Fixes #6599