Add an 'spk config' command - #1406
Open
jrray wants to merge 1 commit into
Open
Conversation
Mirrors 'spfs config': prints the effective spk configuration, after the system file, user file, and environment variable overrides have all been merged, as pretty-printed json. This gives users a way to check what spk actually resolved its settings to, which is otherwise only inferable from behavior. The command lives in spk-cli-group4 alongside the other small informational commands. That crate sits on the tail of the build's critical path (spk-cli-group2 rmeta -> spk-cli-group4 -> spk), so the placement was measured rather than assumed: across from-scratch builds and repeated cold rebuilds of the crate, the added module moves the group4 compile by -32ms against a +/-250ms run-to-run spread. The spk-config dependency added here is a new direct edge to a crate that was already present transitively and finishes ~58s before group4 starts, so it adds no node to the graph and lengthens no path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XsbWihJL8svBWeeKHNL2j9
Collaborator
Author
|
I noticed an LLM looking for a |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
spk config, mirroring the existingspfs configcommand.It prints the effective spk configuration — after the system file, the user
file, and environment variable overrides have all been merged — as
pretty-printed json. Today there is no way to check what spk actually resolved
its settings to other than inferring it from behavior.
Placement
The command lives in
spk-cli-group4alongside the other small informationalcommands (
version,lint,search,view).That crate turns out to sit on the tail of the build's critical path —
spk-cli-group2rmeta →spk-cli-group4→spklink — with nothing elsegating the final link, so the placement was measured rather than assumed:
spk configcargo build -p spkspk-cli-group4unitSince that spread is all noise, the crate was isolated (deps warm,
cargo clean -p spk-cli-group4,CARGO_INCREMENTAL=0, 3 reps each):baseline mean 6087ms vs. 6055ms with the change — −32ms against a ±250ms
run-to-run spread, i.e. unmeasurable.
That matches the structure: the new module is 30 lines with no generics or
macro expansion, and the
spk-configdependency added to group4'sCargo.tomlis a new direct edge to a crate that was already presenttransitively and finishes ~58s before group4 starts — it adds no node to the
graph and lengthens no path.
Worth knowing for later, though: anything heavier landing in group4 goes
straight onto the critical path's tail.
Also
spfs configandspk configindocs/admin/config.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01XsbWihJL8svBWeeKHNL2j9