Backport bug fixes from spi-release-0.47 - #1395
Open
jrray wants to merge 8 commits into
Open
Conversation
Add module-level unused_assignments allowances to the thiserror-heavy error modules and migration graph code that now trigger macro-generated warnings under Rust 1.93 while linting with -Dwarnings. Also mark the cmd-build environment-ops test with spfstest so the staged branch state continues to pass the test suite. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: J Robert Ray <jrray@imageworks.com>
Use the global solver.use_indexes setting when a non-destructive repo operation reaches an unconfigured repository instead of assuming every non-local repo should use an index. Add a regression test that exercises an unconfigured origin repo, and serialize it under a dedicated spk_config lock because it mutates the global spk config. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: J Robert Ray <jrray@imageworks.com>
Add spk-rl9.spec, the Rocky Linux 9 RPM build spec for the SPI internal build, alongside the existing spk.spec for RHEL 7/8. The rl9 variant enables the legacy-mount-options and fuse-backend-rhel-7-9 features, uses cmake3 (with a fallback to cmake for forward-compatibility), and requires libcurl-devel for the rdkafka-sys build. Also add 'buildrequires' and 'rpmspec' to the cspell dictionary. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: J Robert Ray <jrray@imageworks.com>
jrray
force-pushed
the
backport-0.47-fixes
branch
from
July 9, 2026 00:21
43640a7 to
e611003
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Remove the spurious checked_objects increment from CheckObjectError::Missing::summary(). A missing object was never actually checked, so it should not contribute to checked_objects. Update the regression test to expect 1 checked object instead of 2. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: J Robert Ray <jrray@imageworks.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: J Robert Ray <jrray@imageworks.com>
jrray
force-pushed
the
backport-0.47-fixes
branch
from
July 9, 2026 00:46
5b1f553 to
e713d62
Compare
Update .site/spi/spk.spec to match the internal build spec, keeping public version/provides numbers at 0.44.0. This brings over internal build requirements and packaging file layout, but keeps public cargo feature usage aligned with public spfs by omitting spfs/legacy-mount-options. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: J Robert Ray <jrray@imageworks.com>
Remove spfs/legacy-mount-options from the public Rocky 9 RPM build flags in .site/spi/spk-rl9.spec so the spec only references features that exist in public spfs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: J Robert Ray <jrray@imageworks.com>
jrray
force-pushed
the
backport-0.47-fixes
branch
from
July 9, 2026 00:51
1c53b7a to
8a17571
Compare
Add .site/spi/spk-pkg-metadata.sh from the internal release branch so the public SPI specs can include it in RPM payloads. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: J Robert Ray <jrray@imageworks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eight fixes from the internal
spi-release-0.47-githubrelease branch that were never merged to public main.Handle Rust 1.93 lint regressions — adds
#![allow(unused_assignments)]tothiserror-heavy error modules and the migration graph code that now trigger macro-generated warnings under Rust 1.93 when linting with-Dwarnings. Also marks the cmd-build environment-ops test with#[spfstest].Disable default repo index use — when a non-destructive repo operation reaches an unconfigured repository, respect the global
solver.use_indexessetting rather than enabling index use on every non-local repo unconditionally. Adds a regression test exercising an unconfigured origin repo, serialized under aserial_testlock because it mutates global spk config.Add SPI Rocky 9 RPM spec — add
.site/spi/spk-rl9.spec, the Rocky Linux 9 RPM build spec maintained on the internal branch. It matches internal content except version-number fields.Fix spfs check summary for missing objects — removes the spurious
checked_objects: 1increment fromCheckObjectError::Missing::summary()and updates the regression test accordingly.Bump cached from 0.48.1 to 0.54.0 — also drops the now-unused
darlingandinstanttransitive dependencies.Sync SPI spk.spec with internal branch — update
.site/spi/spk.specto match internal build requirements, build flags, and file installs (includingspfs-winfsp), while keeping publicVersion/Providesvalues at0.44.0.Stop passing legacy-mount-options in public SPI specs — remove
spfs/legacy-mount-optionsfrom both public SPI spec cargo feature lists (.site/spi/spk.specand.site/spi/spk-rl9.spec) so they reference only features that exist in public spfs.Add SPI package metadata helper script — add
.site/spi/spk-pkg-metadata.shfrom the internal branch so SPI RPM specs can include it in the package payload.