Skip to content

Verify payload contents in spfs check - #1376

Open
jrray wants to merge 1 commit into
mainfrom
verify-payload-contents-check
Open

Verify payload contents in spfs check#1376
jrray wants to merge 1 commit into
mainfrom
verify-payload-contents-check

Conversation

@jrray

@jrray jrray commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a --verify-payload-contents flag to spfs check
  • re-hash payload files to detect on-disk corruption, not just missing payloads
  • report invalid payloads separately and repair them with --pull

Testing

  • cargo test -p spfs check_test -- --nocapture
  • make nextest lint

Add a --verify-payload-contents flag to spfs check so callers
can rehash payload files instead of only checking for their
presence.

Track invalid payloads in check summaries, surface them in CLI
output, and repair them by resyncing payload data when --pull
is enabled.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: J Robert Ray <jrray@imageworks.com>
@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.78947% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/spfs/src/check.rs 79.41% 14 Missing ⚠️
crates/spfs-cli/main/src/cmd_check.rs 0.00% 9 Missing ⚠️

📢 Thoughts on this report? Let us know!

@jrray jrray self-assigned this May 28, 2026
@jrray jrray added enhancement New feature or request AI Code authored with AI assistance. labels May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Code authored with AI assistance. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants