Make environment variables to preserve configurable - #1148
Merged
Conversation
jrray
force-pushed
the
preserve-env-var-config
branch
6 times, most recently
from
November 23, 2024 10:41
2fd6b58 to
17e340f
Compare
We were preserving $TMPDIR specfically in a hard-coded way and there was no way to opt out of it if desired. Now it has come to light that $LD_LIBRARY_PATH is also cleared when entering an spfs runtime. We would like to preserve that value too. Add a new configuration option so each site can decide to opt in to the preserving. Doing so may come with risks of privilege escalation. Signed-off-by: J Robert Ray <jrray@jrray.org>
jrray
force-pushed
the
preserve-env-var-config
branch
from
November 23, 2024 10:52
17e340f to
b1854b7
Compare
Collaborator
Author
|
Didn't mean to close this. Too many tabs open... |
rydrman
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were preserving $TMPDIR specfically in a hard-coded way and there was no way to opt out of it if desired. Now it has come to light that $LD_LIBRARY_PATH is also cleared when entering an spfs runtime. We would like to preserve that value too. Add a new configuration option so each site can decide to opt in to the preserving. Doing so may come with risks of privilege escalation.