default runtime dir use temp_dir - #1108
Draft
doubleailes wants to merge 2 commits into
Draft
Conversation
rydrman
reviewed
Aug 20, 2024
Contributor
Author
|
Sorry i did not comment the suggestion but i accepted it. cheers. |
doubleailes
force-pushed
the
dynamic_runtime_dir
branch
from
August 29, 2024 18:04
1591c9b to
247e0f9
Compare
rydrman
approved these changes
Aug 31, 2024
Collaborator
|
@jrray FYI as I'm not sure if you use a separate temp dir at SPI. I will double check at ILM as we do but I don't think this has any negative impact |
Collaborator
On Linux we're mounting a tmpfs here, in the private mount namespace, right? I want to say that means the path doesn't matter too much. |
Signed-off-by: Philippe Llerena <philippe.llerena@gmail.com>
Co-authored-by: Ryan Bottriell <ryan@bottriell.ca> Signed-off-by: Philippe Llerena <charlesbrenten@hotmail.com>
doubleailes
force-pushed
the
dynamic_runtime_dir
branch
from
September 2, 2024 10:24
247e0f9 to
1116dc7
Compare
Contributor
Author
|
I rebase to get the #1119 changes |
Contributor
Author
|
Since test are running and get error, i need to look deeper into it. Move back to draft. |
doubleailes
marked this pull request as draft
September 4, 2024 08:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR remove
cont RUNTIME_DIRto usetemp_dir()and support windows temp dir