Add Bitgesell#277
Conversation
|
Thank you @zuhairalbitar for approving the PR. was waiting for this refreshing page everyday! |
|
;) |
|
Looks good to me! 💯 Got a fork based on the above approved by changes @wu-emma powering transactions indexing for |
| @classmethod | ||
| def header_hash(cls, header): | ||
| '''Given a header return hash''' | ||
| return keccak_256(header) |
There was a problem hiding this comment.
Please don't pollute hash.py with altcoins.
Instead, hide everything inside the header_hash(_rev) method. See e.g. Dash:
electrumx/src/electrumx/lib/coins.py
Lines 1284 to 1288 in 8da652a
| class DeserializerSegWitBGL(DeserializerSegWit): | ||
| TX_HASH_FN = staticmethod(sha256) |
There was a problem hiding this comment.
put this near the bottom of the file instead
|
Given the recent comment I guess this altcoin is still alive. If you still want to add it, fix the comments and rebase. |
Thank you so much @SomberNight. @wu-emma I can take on this/ready to help out |
No description provided.