Skip to content

Add Bitgesell#277

Open
wu-emma wants to merge 3 commits into
spesmilo:masterfrom
BitgesellOfficial:bgl
Open

Add Bitgesell#277
wu-emma wants to merge 3 commits into
spesmilo:masterfrom
BitgesellOfficial:bgl

Conversation

@wu-emma

@wu-emma wu-emma commented Sep 29, 2024

Copy link
Copy Markdown

No description provided.

@wu-emma

wu-emma commented Nov 25, 2024

Copy link
Copy Markdown
Author

Thank you @zuhairalbitar for approving the PR. was waiting for this refreshing page everyday!
please ping me if you need any details to merge it.

@wu-emma

wu-emma commented Mar 17, 2025

Copy link
Copy Markdown
Author

;)

@naftalimurgor

naftalimurgor commented Jun 20, 2026

Copy link
Copy Markdown

Looks good to me! 💯

Got a fork based on the above approved by changes @wu-emma powering transactions indexing for
https://explorer.bitgesell.dev secondary block explorer for Bitgesell

Comment thread electrumx/lib/coins.py
Comment on lines +4263 to +4266
@classmethod
def header_hash(cls, header):
'''Given a header return hash'''
return keccak_256(header)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't pollute hash.py with altcoins.
Instead, hide everything inside the header_hash(_rev) method. See e.g. Dash:

@classmethod
def header_hash_rev(cls, header):
'''Given a header return the hash.'''
import dash_hash
return dash_hash.getPoWHash(header)

Comment thread electrumx/lib/tx.py
Comment on lines +315 to +316
class DeserializerSegWitBGL(DeserializerSegWit):
TX_HASH_FN = staticmethod(sha256)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put this near the bottom of the file instead

@SomberNight

Copy link
Copy Markdown
Member

Given the recent comment I guess this altcoin is still alive. If you still want to add it, fix the comments and rebase.

@naftalimurgor

Copy link
Copy Markdown

Given the recent comment I guess this altcoin is still alive. If you still want to add it, fix the comments and rebase.

Thank you so much @SomberNight. @wu-emma I can take on this/ready to help out
cc @wu-emma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants