Skip to content

Warn on wildcard remote directories #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huangzesen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Warn on wildcard remote directories #420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions idl/general/spedas_tools/spd_download/spd_download.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,23 @@ if n_elements(local_path) ne 1 then begin
endif


;warn when wildcard characters appear before the final remote path component
;because the remote path is also used to derive local_file below
if strpos(remote_path,'*') ne -1 || strpos(remote_path,'?') ne -1 || strpos(remote_path,'[') ne -1 then begin
dprint, dlevel=1, 'Warning: wildcard characters in remote directory components may produce unexpected local paths: ' + $
remote_path
endif

for i=0, n_elements(remote_file)-1 do begin
remote_dir = file_dirname(remote_file[i])
if remote_dir ne '.' && remote_dir ne '' then begin
if strpos(remote_dir,'*') ne -1 || strpos(remote_dir,'?') ne -1 || strpos(remote_dir,'[') ne -1 then begin
dprint, dlevel=1, 'Warning: wildcard characters in remote directory components may produce unexpected local paths: ' + $
remote_file[i]
endif
endif
endfor

;complete remote file path(s)
url = remote_path + remote_file

Expand Down