macaulay2: drop -lquadmath from FLIBS hack - #6194
Merged
Merged
Conversation
It was causing linking errors on ARM machines, where libquadmath isn't available. It was really only there because we needed something nonempty to avoid AC_FC_LIBRARY_LDFLAGS trying to generate them (resulting in Macaulay2/M2#4074), and -lquadmath there on x86_64. The build works just fine without it.
spackbot-triage
Bot
added
the
update-package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was causing linking errors on ARM machines, where libquadmath isn't available. It was really only there because we needed something nonempty to avoid
AC_FC_LIBRARY_LDFLAGStrying to generate them (resulting in Macaulay2/M2#4074), and-lquadmathwas there on x86_64. The build works just fine without it.