[WIP] Fix broken HTML tag in simple_report_pdf.tpl#2806
Draft
yyq1043-cloud wants to merge 4 commits into
Draft
Conversation
added 4 commits
June 26, 2026 20:05
Adds quick-access links to web archives (Wayback Machine and archive.is) in profile URL report blocks, allowing users to see historical snapshots of profile pages when they still exist but are no longer accessible. Closes soxoj#247
Expand Cloudflare/anti-bot detection to catch more blocking patterns and provide clearer error messages for each type. Addresses the 'filter by errors' TODO from submit mode improvements.
When a site blocks automated access, include the HTTP status codes from the existing/non-existing account responses in the error message for easier debugging.
Contributor
Author
|
Hi! I'd like to request review for this PR: Fix broken HTML tag in simple_report_pdf.tpl |
Owner
|
Thanks! The one-line |
soxoj
changed the title
Contributor
Author
|
Hi! I'd like to request review for this PR: [WIP] Fix broken HTML tag in simple_report_pdf.tpl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
simple_report_pdf.tpltemplate contains a malformed<html>tag on line 1:<html>type="text/css"— the>is missing before the straytypeattribute, which makes the HTML invalid and can cause rendering issues in PDF report generators.Fix
Changed
<html>type="text/css"to<html>.The orphaned
type="text/css"fragment was not referencing any actual CSS rules (no<style>tag or linked stylesheet exists in the template), so removing it causes no functional regression.Testing
Verified the template Jinja2 variables (
{{ username }},{{ generated_at }}, etc.) remain intact. The template structure is otherwise unchanged.