Skip to content

Test teams api drift - #30

Open
ceciliaavila wants to merge 4 commits into
southworks/add/teams-api-driftfrom
ceci/test/teams-api-drift
Open

Test teams api drift#30
ceciliaavila wants to merge 4 commits into
southworks/add/teams-api-driftfrom
ceci/test/teams-api-drift

Conversation

@ceciliaavila

Copy link
Copy Markdown
Collaborator

minor

Test

Copilot AI lite review requested due to automatic review settings August 28, 2026 18:30
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 16 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dad9dabb-f1e6-4642-9f93-57d128c371af

📥 Commits

Reviewing files that changed from the base of the PR and between 778cb54 and 3b601bc.

📒 Files selected for processing (2)
  • .github/workflows/teams-api-drift-pr.yml
  • Directory.Packages.props

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62c0c413-d7b6-452e-b6fb-56c887892b05

📥 Commits

Reviewing files that changed from the base of the PR and between 9197590 and 778cb54.

📒 Files selected for processing (3)
  • .github/workflows/teams-api-drift-pr.yml
  • Directory.Packages.props
  • scripts/TeamsApiDrift/teams-api-usage.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The drift workflow now targets an additional branch. The Teams Apps package property and API usage fixture now use version 2.1.0-driftfixture.20260827.1.

Changes

Teams Apps drift fixture

Layer / File(s) Summary
Workflow trigger
.github/workflows/teams-api-drift-pr.yml
The pull-request workflow now targets southworks/add/teams-api-drift.
Version alignment
Directory.Packages.props, scripts/TeamsApiDrift/teams-api-usage.json
The package property and API usage fixture now use 2.1.0-driftfixture.20260827.1. The project file closing tag has newline formatting adjusted.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 778cb

This PR makes localized test-fixture and workflow-target changes, with no actionable merge-blocking risk remaining after normal checks and review.

Poem

A rabbit checks the version line
The drift fixture now aligns
A workflow branch joins the run
Package and JSON match as one
Hop, hop—validation is done!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description indicates a minor test change, but it does not explain which Teams API drift workflow or fixtures were updated. Add a brief summary of the Teams API drift workflow, package version, and usage fixture changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the main change: testing Teams API drift. It is concise and related to the workflow and fixture updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ceci/test/teams-api-drift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Teams API drift test inputs by switching the declared Microsoft.Teams.Apps version to a local “drift fixture” build.

Changes:

  • Updated the Teams API usage manifest to declare a drift-fixture version.
  • Updated central package management to use a drift-fixture version for Microsoft.Teams.Apps.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
scripts/TeamsApiDrift/teams-api-usage.json Changes the drift manifest’s declaredVersion value used during usage validation.
Directory.Packages.props Changes the centrally-managed Microsoft.Teams.Apps version property used for restores/builds.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Directory.Packages.props Outdated
<Xunit_v3_PackageVersion>3.0.1</Xunit_v3_PackageVersion>
<Microsoft_Teams_Apps_PkgVer Condition="'$(Microsoft_Teams_Apps_PkgVer)' == ''">2.1.0</Microsoft_Teams_Apps_PkgVer>
<Xunit_v3_PackageVersion>3.0.1</Xunit_v3_PackageVersion>
<Microsoft_Teams_Apps_PkgVer Condition="'$(Microsoft_Teams_Apps_PkgVer)' == ''"><Microsoft_Teams_Apps_PkgVer>2.1.0-driftfixture.20260827.1</Microsoft_Teams_Apps_PkgVer></Microsoft_Teams_Apps_PkgVer>
"schemaVersion": 1,
"package": "Microsoft.Teams.Apps",
"declaredVersion": "2.1.0",
"declaredVersion": "2.1.0-driftfixture.20260827.1",
@ceciliaavila
ceciliaavila force-pushed the ceci/test/teams-api-drift branch from 778cb54 to 1532e62 Compare August 28, 2026 18:39
@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown

Teams API drift analysis

Compared 2.1.0 to 2.1.0-driftfixture.20260827.1.
The analysis identified 18 total findings, of which 13 require attention.
Blocking: 5 · Required: 4 · Review: 4.

  • MTAPI-0003 — review · member-added: Microsoft.Teams.Apps.Clients.ApiClient.DriftFixtureAdded
  • MTAPI-0005 — required · base-type-changed: Microsoft.Teams.Apps.ConversationEventType
  • MTAPI-0006 — blocking · symbol-kind-changed: Microsoft.Teams.Apps.ConversationEventType
  • MTAPI-0007 — required · member-signature-changed: Microsoft.Teams.Apps.ConversationEventType.ChannelCreated
  • MTAPI-0010 — blocking · member-accessibility-changed: Microsoft.Teams.Apps.Files.FileConsentValue.Action

Full report and artifacts

@ceciliaavila
ceciliaavila force-pushed the southworks/add/teams-api-drift branch from 7458721 to 4ccf53a Compare August 31, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants