Repository navigation
Restore existing wallet keys and derive Taira accounts for retained mnemonics - #477
Draft
takemiyamakoto wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release successor: #478 carries the additional recovery diagnostics in build 2026091302. Build 2026091301 was never uploaded.
An upgrade can stop with
missing_wallet_secretwhen the existing account row survives but its signing credentials are unavailable. This adds on-device phrase recovery that proves the retained address and public key before adding only absent credentials, then reruns full startup verification. Existing accounts and credentials are never replaced by this recovery action.Taira derivation and signing now support all retained BIP39 phrase lengths (12, 15, 18, 21, and 24 words). Older staged or active SORA-only snapshots resume by appending deterministic network accounts, and the post-import check accepts the resulting Taira accounts while preserving legacy identities and retained evidence.
All 271 Release wallet tests passed with zero failures or skips and identical hashes for all 6,085 tracked files before and after validation. Eleven targeted recovery and previously failing checks, eight publication tests, contract lint, native archive signature verification, and runtime dependency closure also passed. Build 2026091301 archived successfully but was never uploaded or installed; it is superseded as the release candidate by diagnostic successor #478, build 2026091302. The primary checkout contains the exact tested correction with its existing index and unrelated changes preserved.
The connected-device inspection established missing accessible signing credentials, but not when or why they became unavailable. Recovery of that phone still requires its original phrase to be entered by the user directly on the device; no successful recovery is claimed. Private phone contents are excluded from this PR.