Repository navigation
Recover interrupted legacy wallet activation and publish TestFlight 0704 - #473
Draft
takemiyamakoto wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pre-account legacy wallet could remain blocked after an interrupted first-account upgrade even though its original keys and account were intact. Startup now verifies the retained legacy identity, account data, network children and saved selection before resuming the account commit. A verified first snapshot written before its active pointer is activated in place. Journal and recovery-marker checks prevent a later or conflicting recovery condition from being cleared; original keys and snapshot bytes are preserved.
The added tests restart from persisted account-commit stages, including staged-only snapshots and interruptions during recovery, and reject altered or ambiguous evidence.
Validation: Release simulator build passed; all 247 distinct wallet regression tests passed with zero failures/skips. The two new activation methods also passed independently. All 6,085 tracked file hashes remained unchanged; runtime
e886d7cfacbff119cb9bcb961cfc213882675636contains those exact tested bytes. Coverage uses persisted simulator restart states.All 8 upload-contract tests passed. Clean pushed publication source
ab0f3310fa9339c5716f09663ed53553d8ad3347changes only the four publication contracts, using build 2026090704 with 2026090703 as the lower bound.Internal TestFlight 3.8.7 (2026090704) uploaded successfully at
2026-09-07T08:43:36Z, delivery5ed3f630-b2db-4c25-9190-cbb071729c23. Exact package source/build, internal-only flag, signature, provisioning profile, entitlements and runtime dependency closure passed verification; Organizer reported no errors/warnings. Apple processing is complete; the build is Testing for the existing App Store Connect Users internal group (2 testers), with the upgrade instructions saved.Public-link distribution correction: the same verified archive was exported by Xcode as 3.8.7 (2026090705) with external distribution enabled and accepted by Apple at
2026-09-07T09:42:41Z, delivery6b6eb0b1-429a-4ba7-995f-779f0e675809. All 10 unsigned binaries and non-signing resources match the verified archive. The only app metadata change is the build number. Apple processing is complete. Both existing public-link groups, SORA Externals (62 testers) and Early adopters (10 testers), are assigned. Beta review is submitted with automatic tester notification enabled; external access awaits Apple approval.