Skip to content

[cacl][test] Expect dhcp_server docker0 syslog rule on tcp/2514 #26477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xichen96 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[cacl][test] Expect dhcp_server docker0 syslog rule on tcp/2514 #26477

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94dffbd
[cacl][test] Expect dhcp_server docker0 syslog rule on tcp/2514
Xichen96 Jul 22, 2026
1776ee5
Use duthost.get_feature_status() helper for dhcp_server gate
Xichen96 Jul 23, 2026
2e817d7
Shorten dhcp_server gate comment to a single line
Xichen96 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions tests/cacl/test_cacl_application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,11 +578,19 @@ def generate_expected_rules(duthost, tbinfo, docker_network, asic_index, expecte
.format(v['IPv6Address'],
docker_network['bridge']['IPv6Address']))

# dhcp_server uses bridge networking; its startup script adds an iptables
# rule to allow syslog (UDP 514) past caclmgrd's catch-all DROP.
if "dhcp_server" in docker_network['container']:
# dhcp_server and redfish both run in bridge mode, but only
# dhcp_server's rsyslog reaches the host over docker0 via RELP
# (tcp/2514). caclmgrd owns the INPUT ACCEPT
# exception for that traffic and re-emits it on every control-plane ACL
# flush-and-rebuild while FEATURE|dhcp_server is enabled, so the rule
# survives the rebuild. Gate the expectation on the feature state that
# caclmgrd keys on, not merely on the container being present.
dhcp_server_feature_state = duthost.shell(
"sonic-db-cli CONFIG_DB HGET 'FEATURE|dhcp_server' state",
module_ignore_errors=True)['stdout'].strip()
if dhcp_server_feature_state == "enabled":
iptables_rules.append(
Comment thread
Xichen96 marked this conversation as resolved.
"-A INPUT -i docker0 -p udp -m udp --dport 514"
"-A INPUT -i docker0 -p tcp -m tcp --dport 2514"
" -m comment --comment dhcp_server_syslog -j ACCEPT")

else:
Expand Down
Loading