Add SYSTEM_DEFAULTS['decap_qos_map'] to control IPInIP decap_dscp_to_tc_map#28588
Open
markx-arista wants to merge 1 commit into
Open
Add SYSTEM_DEFAULTS['decap_qos_map'] to control IPInIP decap_dscp_to_tc_map#28588markx-arista wants to merge 1 commit into
markx-arista wants to merge 1 commit into
Conversation
Use SYSTEM_DEFAULTS['decap_qos_map']['status'] to control decap_dscp_to_tc_map instead of hardcoded ASIC vendor and hwsku checks. The decap_qos_map default is set in init_cfg.json.j2 (disabled for broadcom, enabled for others) and can be overridden per-SKU via golden config. Signed-off-by: markxiao <markxiao@arista.com>
markx-arista
requested review from
dgsudharsan,
lguohan,
praveen-li,
qiluo-msft and
venkatmahalingam
as code owners
July 23, 2026 00:27
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
markx-arista
marked this pull request as draft
July 23, 2026 00:29
markx-arista
marked this pull request as ready for review
July 23, 2026 05:41
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
This PR has backport request for branch(es): 202511,202605. ---Powered by SONiC BuildBot
|
Collaborator
|
This PR has backport request label(s) for branch(es): 202511,202605, but is missing required test information. Please make sure you tick the tested branch(es) in the Tested branch section and provide test evidence (e.g., 202511: <test result>) in the Test result section as well in your PR description. ---Powered by SONiC BuildBot
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Currently ipinip.json.j2 is having platform checks for enabling/disabling decap entries. We want to prevent having platform checks for simple enable/disable scenarios.
Work item tracking
How I did it
Use SYSTEM_DEFAULTS['decap_qos_map']['status'] to control decap_dscp_to_tc_map instead of hardcoded ASIC vendor and hwsku checks. The decap_qos_map default is set in init_cfg.json.j2 (disabled for broadcom, enabled for others) and can be overridden per-SKU via golden config.
How to verify it
decap_qos_remap is set to disabled for Broadcom platforms, and enabled for others.
Which release branch to backport (provide reason below if selected)
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO):
Failure type:
Tested branch
Test result
With decap_qos_map disabled, decap_dscp_to_tc_map is not set:
With golden config enabling decap_qos_map:
Description for the changelog
Use SYSTEM_DEFAULTS['decap_qos_map']['status'] to control decap_dscp_to_tc_map
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)