Add aspeed platform service to disable boot watchdog timer A (WDTA)#28573
Open
prajjwal-arista wants to merge 1 commit into
Open
Add aspeed platform service to disable boot watchdog timer A (WDTA)#28573prajjwal-arista wants to merge 1 commit into
prajjwal-arista wants to merge 1 commit into
Conversation
When ABR (Alternate Bootblock Recovery) is enabled, SONiC is expected to bootup and stop the WDTA. This service starts early in the sequence, before local-fs.target, and disarms WDTA by clearing the enable bit in the WDTA control register. Signed-off-by: Prajjwal Singh <prajjwal@arista.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Collaborator
|
This PR has backport request for branch(es): 202608. ---Powered by SONiC BuildBot
|
Collaborator
|
This PR has backport request label(s) for branch(es): msft-202608, but is missing required test information. Please make sure you tick the tested branch(es) in the Tested branch section and provide test evidence (e.g., 202608: <test result>) in the Test result section as well in your PR description. ---Powered by SONiC BuildBot
|
Contributor
|
Refer HLD for background: sonic-net/SONiC#2470 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
When ABR (Alternate Bootblock Recovery) is enabled, SONiC is expected to bootup and stop the WDTA.
This is required by the ABR mechanism to stop booting from resetting and booting from secondary boot source
HLD PR : sonic-net/SONiC#2470
Work item tracking
How I did it
Added a service that starts early in the sequence, before local-fs.target, and disarms WDTA by clearing the enable bit in the WDTA control register.
NOTE - On device where ABR is not enabled the service shall not do anything.
Here we simply switch the enable bit to 0 on the WDTA control register, which shall not do anything on device with ABR enabled
How to verify it
On ABR enabled BMC aspeed 2700 devie, run the service and expect following logs:
Which release branch to backport (provide reason below if selected)
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO):
Failure type:
Tested branch
Test result
The introduced service is successfully able to disable the WDTA on bootup in time, on ABR enabled dut -
On DUT where ABR is not enabled, the service simply tries to flip the WDTA ctrl bit , which doesn't do anything and doesn't create any problems. the system runs fine.
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)