[CPO] Update CPO Port Mapping HLD with Minor Corrections - #2469
Open
bgallagher-nexthop wants to merge 3 commits into
Open
[CPO] Update CPO Port Mapping HLD with Minor Corrections#2469bgallagher-nexthop wants to merge 3 commits into
bgallagher-nexthop wants to merge 3 commits into
Conversation
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
bgallagher-nexthop
marked this pull request as ready for review
July 21, 2026 23:39
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
…ment Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
prgeor
approved these changes
Jul 23, 2026
prgeor
left a comment
prgeor
left a comment
Contributor
There was a problem hiding this comment.
@eddyk-nvidia @micas-net please review
micas-net
reviewed
Jul 24, 2026
Comment on lines
-151
to
+152
| // laser_to_lane_mapping provides a mapping of laser to which lane it is powering. | ||
| "laser_to_lane_mapping": { | ||
| // laser_to_asic_lane_mapping provides a mapping of laser to which ASIC lane it is powering. | ||
| "laser_to_asic_lane_mapping": { |
Contributor
There was a problem hiding this comment.
What kind of lane does asic lane want to distinguish？
Contributor
Author
There was a problem hiding this comment.
asic_lane in this file refers to the ASIC SerDes lanes that interface with the on-package optical engine.
tshalvi
reviewed
Jul 27, 2026
| def construct_sfp_list_for_topology(self, cpo_data): | ||
| """Subclasses should implement this method to create sfp objects based on topology data in cpo.json""" | ||
| def construct_cpo_devices(self, cpo_data): | ||
| """Subclasses should implement this method to create CPO objects based on topology data in cpo.json""" |
Contributor
There was a problem hiding this comment.
Could you please clarify what cpo.json is? Is it another name for optical_devices.json?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some minor updates to the port mapping HLD to reflect the latest code changes made in the following PRs:
Changes:
ChassisBasechanges to store CPO objects inself._cpo_list.cpo.jsonschema.