[acl] HLD: document ECN_ACTION ACL marking action - #2464
Open
yanmo96 wants to merge 1 commit into
Open
Conversation
Add the ECN_ACTION L3 ACL action to the ACL High Level Design: a functional requirement, the App DB ACL Rules Table schema entry, Table 5 (actions allowed in the L3 table type), and a revision row. ECN_ACTION sets the IP ECN field (low 2 bits of the IPv4 TOS / IPv6 Traffic Class byte) to a value in [0..3] per RFC 3168 and maps to SAI_ACL_ENTRY_ATTR_ACTION_SET_ECN. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Yan Mo <andymo96@gmail.com>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I'm doing
Support ACL-based ECN marking for packets selected by UDP source port.
Documents a new
ECN_ACTIONL3 ACL action in the ACL High Level Design.ECN_ACTIONsets the IP ECN field (the low 2 bits of the IPv4 TOS / IPv6Traffic Class byte) to a value in
[0..3]per RFC 3168, and maps toSAI_ACL_ENTRY_ATTR_ACTION_SET_ECN. This lets selected traffic (e.g. matchedby an ingress L3/L3V6 rule) be ECN-marked in hardware.
Changes to
doc/acl/ACL-High-Level-Design.mdECN_ACTION = 1DIGITgrammar entry(
0=Non-ECT, 1=ECT(1), 2=ECT(0), 3=CE).L3table type) – add theECN_ACTION | uint8_trow.Documentation only — no code in this repo.
Implementation & tests (separate PRs)
ECN_ACTIONleaf + Configuration.md + YANG testsacl_loaderdisplay supportHow verified
control-plane rule shows
ECN: 3Active and the ASIC programsSAI_ACL_ENTRY_ATTR_ACTION_SET_ECN = 3.forwarding is unaffected).