HLD for Redfish Certificate Provisioning Integration#2461
Open
shreyansh-nexthop wants to merge 2 commits into
Open
HLD for Redfish Certificate Provisioning Integration#2461shreyansh-nexthop wants to merge 2 commits into
shreyansh-nexthop wants to merge 2 commits into
Conversation
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
shreyansh-nexthop
marked this pull request as ready for review
July 13, 2026 11:42
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
shreyansh-nexthop
force-pushed
the
shreyansh.redfish_acms_integration
branch
from
July 14, 2026 07:08
ba9b34e to
42192c3
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
shreyansh-nexthop
changed the title
judyjoseph
reviewed
Jul 15, 2026
| - **Automatic certificate consumption.** A staging helper (`stage-credentials.sh`) inside the redfish container reshapes the provisioned files from `/etc/sonic/credentials/` (`server.crt`, `server.key`, `server_ca.crt`) into what bmcweb expects: a combined `server.pem`, a CA truststore with its `<hash>.0` symlink. bmcweb's code is untouched. | ||
| - **Automatic rotation.** A watcher picks up installs and rotations (inotify, plus a 60 second reconcile as a safety net) and restarts bmcweb, since bmcweb reads certificates only at startup. A cert/key pair guard ensures a mid-rotation mismatch is never staged. | ||
| - **mTLS enforcement.** `TLSStrict` and CN-to-local-user mapping (`MTLSCommonNameParseMode 2`) are enabled once, at first provisioning. Clients must present a certificate signed by the staged CA whose CN names a local BMC user. | ||
| - **Secure mode (fail closed).** A CONFIG_DB flag, `DEVICE_METADATA|localhost` field `redfish_secure_mode`, is auto-set at first provisioning. Once on, every bmcweb start is gated: with no valid staged certificate, bmcweb does not start at all, instead of falling back to a self-signed cert. Recovery is automatic when valid certs reappear. |
Contributor
There was a problem hiding this comment.
suggest to keep it out of DEVICE_METADATA .. we can keep it as a separate table for REDFISH -- something like this - is this ok ?
"REDFISH": {
"AUTHENTICATION_MODE": {
"secure_mode": "true"
}
}
Author
There was a problem hiding this comment.
Sure, I've moved the flag out of DEVICE_METADATA into a dedicated REDFISH table as you proposed:
"REDFISH": {
"AUTHENTICATION_MODE": {
"secure_mode": "true"
}
}
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
High-level design for staging externally provisioned certificates into the redfish (bmcweb) container and enforcing mTLS, without modifying bmcweb. Signed-off-by: shreyansh-nexthop <shreyansh@nexthop.ai>
Address review comment: keep the secure-mode policy out of DEVICE_METADATA and store it in REDFISH|AUTHENTICATION_MODE:secure_mode instead. Signed-off-by: shreyansh-nexthop <shreyansh@nexthop.ai>
shreyansh-nexthop
force-pushed
the
shreyansh.redfish_acms_integration
branch
from
July 16, 2026 19:33
84d18b2 to
8b2b38c
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.