Fix/source url fallback with minor UI#457
Merged
Merged
Conversation
Rename the lobby sort options to "Recent" and "Unread" and give the recency/unread section headers a stable ValueKey so tests can target a header independently of the identically-labelled sort option. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Prefer the backend viewer source_url for a document's source link. When it is absent, derive the citation link from the document URI via a consumer-injected resolver; otherwise show the URI as non-clickable text (it is never itself launchable). Expose the resolver as a seam through standard(documentBrowserUrl:) / standardFlavor(...), installed as a documentBrowserUrlResolverProvider override by a module, with the DocumentBrowserUrlResolver type on the public API. Validate resolver output as an http/https URL and guard the call so a throwing resolver degrades to no link. Log a malformed backend source_url at the citation and document parse sites, and log an http(s) launch failure as an error. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the document source link shown on citations, the room document listing, and the document filter, and revives the consumer-injectable browser-URL resolver as a permanent fallback.
Link precedence per surface:
source_url(launchablehttp/https) → clickableBrowserUrlLinkBrowserUrlLinkThe document listing/filter read
source_urldirectly and do not use the resolver.Consumer seam
A deployment supplies its rule via
standard(documentBrowserUrl: ...)/standardFlavor(documentBrowserUrl: ...), installed as adocumentBrowserUrlResolverProvideroverride by a module.DocumentBrowserUrlResolveris exported; the provider stays internal. Resolver output is validated ashttp/https, and the call is guarded so a throwing resolver degrades to no link instead of crashing.Also
source_urlis logged (distinct from absent);http(s)launch failures log at error.Testing
flutter analyze: clean.soliplex_client: passes (4 pre-existingtest/http/real-TCP flakes only, untouched).