Repository navigation
Re-add code from toml harvest plugin from the other repository - #496
Merged
zyzzyxdonta merged 9 commits intoSep 4, 2026
Merged
Conversation
zyzzyxdonta
force-pushed
the
refactor/fix-pyproject-toml-plugin
branch
from
September 3, 2026 12:40
9e72b2b to
b4c5f31
Compare
Contributor
Author
|
Plugin is currently "broken" for hermes itself because it can't deal with |
zyzzyxdonta
force-pushed
the
refactor/fix-pyproject-toml-plugin
branch
from
September 4, 2026 07:51
c451972 to
d4a5b10
Compare
zyzzyxdonta
marked this pull request as ready for review
September 4, 2026 09:03
Contributor
Author
|
It works now except for two tests that were already broken in the old repo. |
SKernchen
approved these changes
Sep 4, 2026
These days it's very likely that projects using Poetry will have both tables in their `pyproject.toml`. Thus, we should combine the two results, priorityzing the `project` table.
zyzzyxdonta
force-pushed
the
refactor/fix-pyproject-toml-plugin
branch
from
September 4, 2026 10:05
56b595b to
3741305
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/softwarepub/hermes-plugin-python